Refactor history contents API ID encoding #14392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
kind/refactoring
3 tasks
davelopez
force-pushed
the
refactor_history_contents_id_decoding
branch
from
8964aca
to
b9f9d4f
Compare
davelopez
force-pushed
the
refactor_history_contents_id_decoding
branch
2 times, most recently
from
42992d7
to
fdd2734
Compare
Replace `EncodedDatabaseIdField` with `DecodedDatabaseIdField` to remove manual ID decodings from the service layer.
davelopez
force-pushed
the
refactor_history_contents_id_decoding
branch
from
fdd2734
to
48ea02f
Compare
mvdbeek
approved these changes
Aug 11, 2022
|
Very nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #14388 (comment)
Replace
EncodedDatabaseIdFieldwithDecodedDatabaseIdFieldto remove manual ID decodings from the service layer.DecodedDatabaseIdFieldwill now encode the ID when being serialized to JSON in response models. Those pydantic models must descend from the custom base Model.How to test the changes?
License