Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: check for inputs with duplicated names #14604

Merged

Conversation

bernt-matthias
Copy link
Contributor

Just found a case here (macro is expanded twice) https://github.com/galaxyproject/tools-iuc/blob/7a486326f6d0ca87c1c41e857732319d31372799/tools/hyphy/hyphy_fade.xml#L28

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias bernt-matthias force-pushed the topic/lint-duplicate-inputs branch 3 times, most recently from 71a1705 to 3ff56e1 Compare September 12, 2022 14:24
@jmchilton jmchilton merged commit 4236489 into galaxyproject:dev Sep 12, 2022
@jmchilton
Copy link
Member

Wonderful - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants