Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy history from code base #14660

Merged
merged 29 commits into from Sep 22, 2022

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Sep 20, 2022

Follow-up of #14638. This PR removes the legacy history from the code base and drops the analysis bundle size from 20.2MB back to 18.9MB (uncompressed local file size)

It also, includes refactoring for the following two makos:

Additionally this PR removes the legacy iframe handling:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-f2e9637ac05c1a49918232a4003c0d3d74c1bd629eec9920e6c0978048870089L5

The window manager is not required to perform location handling anymore:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-747287c2ddcdbe120610fcdd11f32a0f218a1edb983ea9f10494c5aa0e7e8230L30

Instead it is handled in route processing:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-3dbc3af2db8059af5869467206a457b0bfa9f481f1e87bc0cacf1f7c9ff1521fR73

This PR also contains a fix for handling multiple histories, once retrieved detailed-view properties are now preserved:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-9f0b0b19054c241dfd008b38f14c385df1073ecef759a3e778d7ffe136e1d2e5L35

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Sep 20, 2022
@guerler guerler added this to the 22.09 milestone Sep 20, 2022
@guerler guerler changed the title Remove legacy history usage from makos Remove legacy history from code base Sep 22, 2022
@guerler guerler force-pushed the strip_history_from_makos branch 6 times, most recently from df67908 to 661f090 Compare September 22, 2022 05:28
@guerler guerler marked this pull request as ready for review September 22, 2022 09:40
@bgruening
Copy link
Member

I played around with this branch and could not find any regression :)
Cool work 11k lines gone - bye-bye old history you served us well over so many years.

@guerler
Copy link
Contributor Author

guerler commented Sep 22, 2022

Thank you for testing this.

@bgruening
Copy link
Member

I created #14685 to cleanup the tests a bit.

Great work @guerler

@guerler guerler merged commit 35ba809 into galaxyproject:dev Sep 22, 2022
@guerler
Copy link
Contributor Author

guerler commented Sep 22, 2022

Thanks again for the timely review, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants