New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy history from code base #14660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
added
area/UI-UX
kind/refactoring
cleanup or refactoring of existing code, no functional changes
labels
Sep 20, 2022
guerler
force-pushed
the
strip_history_from_makos
branch
from
September 21, 2022 18:01
ebbf501
to
e2603b3
Compare
guerler
force-pushed
the
strip_history_from_makos
branch
from
September 21, 2022 23:06
e2603b3
to
7911fe4
Compare
guerler
changed the title
Remove legacy history usage from makos
Remove legacy history from code base
Sep 22, 2022
guerler
force-pushed
the
strip_history_from_makos
branch
from
September 22, 2022 01:08
af04e3a
to
635eeda
Compare
guerler
force-pushed
the
strip_history_from_makos
branch
6 times, most recently
from
September 22, 2022 05:28
df67908
to
661f090
Compare
guerler
force-pushed
the
strip_history_from_makos
branch
from
September 22, 2022 05:42
661f090
to
d08196a
Compare
guerler
force-pushed
the
strip_history_from_makos
branch
from
September 22, 2022 09:39
96d390d
to
990dc1e
Compare
I played around with this branch and could not find any regression :) |
Thank you for testing this. |
bgruening
approved these changes
Sep 22, 2022
Thanks again for the timely review, really appreciate it! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #14638. This PR removes the legacy history from the code base and drops the
analysis
bundle size from20.2MB
back to18.9MB
(uncompressed local file size)It also, includes refactoring for the following two makos:
history/display.mako
used for shared histories. It is using the bundledHistoryView
component now, and mounted inside the mako using: https://github.com/galaxyproject/galaxy/pull/14660/files#diff-d0bf6e10f0d44eb04a12c86e53192fa53f6e62444d9f595980fcb9e0b730497aR1history/embedded.mako
is used in Galaxy Pages, which were created using the legacy HTML page editor. In this case embedded legacy histories have been replaced with aName
,Annotation
and aLink to the History
, also leading to theHistoryView
component.Additionally this PR removes the legacy iframe handling:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-f2e9637ac05c1a49918232a4003c0d3d74c1bd629eec9920e6c0978048870089L5
The window manager is not required to perform location handling anymore:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-747287c2ddcdbe120610fcdd11f32a0f218a1edb983ea9f10494c5aa0e7e8230L30
Instead it is handled in
route
processing:https://github.com/galaxyproject/galaxy/pull/14660/files#diff-3dbc3af2db8059af5869467206a457b0bfa9f481f1e87bc0cacf1f7c9ff1521fR73
This PR also contains a fix for handling multiple histories, once retrieved detailed-view properties are now preserved:
https://github.com/galaxyproject/galaxy/pull/14660/files#diff-9f0b0b19054c241dfd008b38f14c385df1073ecef759a3e778d7ffe136e1d2e5L35
How to test the changes?
(Select all options that apply)
License