Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement library/standalone tool shed install functionality. #14833

Closed
wants to merge 26 commits into from

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Oct 20, 2022

  • Introduce a MyPy Protocol that describes what part of "app" is consumed by essentially all the tool shed install and management code - called InstallationTarget.
  • Implement a standalone class (StandaloneInstallationTarget ) that doesn't depend on anything in galaxy-app and can be used to install tools, repositories, data managers, etc... into a directory, manage a simplified toolbox, manage tool data, etc...
  • Introduce an abstraction for the client interaction in the tool shed tests and move all existing implementation details into a "Galaxy API" version.
  • Introduce a second test client interaction implementation that uses a StandaloneInstallationTarget - update CI to run tool shed tests against both in a matrix strategy - so we are testing the Galaxy API as well as the new client install library functionality.

Builds on:

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.


from sqlalchemy import (
and_,
false,
true,
)
from uvloop import install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from uvloop import install

@jmchilton
Copy link
Member Author

I want the testing from #14906 before merging this line of work. I'm going to close and reopen a new slice at this once I've figured out testing better.

@jmchilton jmchilton closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants