Decompose tool shed packages. #14834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
shed_packages
branch
5 times, most recently
from
f512937
to
65e776d
Compare
…tions... ... so we can get the typing right and not depend on app.name.
…ions. Stronger typing and flatter functions
…d ts versions. Avoid all the big conditionals in the middle - again for stronger typing and flatter functions.
the correct home and allows better typing with actual Repository type annotations
Progress toward a separate backend.
This commit creates three new packages - below a description of these packages and why they are being created. galaxy-schema: This package contains the pydantic models that power the API. The purpose of packaging them is to ensure they can be reused by clients with minimal external dependencies. Reusing the schema in client code would very quickly provide rapid documentation and validation and static checking for Python clients using the Galaxy API. galaxy-tool-shed-client: This package contains ``galaxy.tool_shed`` which contains all the code used to manage repositories installations. The purpose of this package is to allow reuse of the tool shed install code in other contexts without all of Galaxy (Planemo, ansible-galaxy-tools). galaxy-tool-shed: This package contains the tool shed server code. This has been a long term project to allow the tool shed to be spun out but maintain real galaxy dependencies and maintain testing. More discussions around this project can be found as part of galaxyproject#8830.
…hed/repository/common.mako
jmchilton
force-pushed
the
shed_packages
branch
from
65e776d
to
9eb1b7d
Compare
|
So this fell apart on the tool validator importing and really using some more stuff from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates three new packages - below a description of these packages and why they are being created.
galaxy-schema: This package contains the pydantic models that power the API. The purpose of packaging them is to ensure they can be reused by clients with minimal external dependencies. Reusing the schema in client code would very quickly provide rapid documentation and validation and static checking for Python clients using the Galaxy API.
galaxy-tool-shed-client: This package contains
galaxy.tool_shedwhich contains all the code used to manage repositories installations. The purpose of this package is to allow reuse of the tool shed install code in other contexts without all of Galaxy (Planemo, ansible-galaxy-tools).galaxy-tool-shed: This package contains the tool shed server code. This has been a long term project to allow the tool shed to be spun out but maintain real galaxy dependencies and maintain testing. More discussions around this project can be found as part of #8830.
This PR builds on #14833.
How to test the changes?
(Select all options that apply)
License