Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button alignment and change external icon in Tools List #15333

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

ahmedhamidawan
Copy link
Member

Changes made to the Tools List/Results page (Fixes #15258):

Changed External button icon

Before After
Screen Shot 2023-01-19 at 1 00 20 AM Screen Shot 2023-01-19 at 1 01 40 AM

Fixed button alignment

Before After
tool_results_button_wrap_Before tool_results_button_wrap_After

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan
Copy link
Member Author

Unrelated Selenium failure: FAILED test/integration_selenium/test_history_import_export_ftp.py::TestHistoryImportExportFtpSeleniumIntegrationWithTasks::test_history_export_tracking

Copy link
Contributor

@guerler guerler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@guerler guerler merged commit 8694724 into galaxyproject:dev Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons in tool search results not aligned properly
2 participants