Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Adjust to bleach.ALLOWED_PROTOCOLS being frozenset #15442

Merged
merged 1 commit into from
Jan 30, 2023
Merged

[23.0] Adjust to bleach.ALLOWED_PROTOCOLS being frozenset #15442

merged 1 commit into from
Jan 30, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 30, 2023 •
edited
Loading

Fixes https://github.com/galaxyproject/galaxy/actions/runs/4042668405/jobs/6950651177#step:7:6788 and works with lists (bleach < 6) and sets (bleach >= 6).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.0 milestone Jan 30, 2023
@mvdbeek mvdbeek mentioned this pull request Jan 30, 2023
Merged
4 tasks
@mvdbeek mvdbeek merged commit 0de1adb into galaxyproject:release_23.0 Jan 30, 2023
@nsoranzo nsoranzo deleted the bleach_frozenset branch January 30, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/dependencies kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mvdbeek @nsoranzo