Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggested Training material to Tool Form #15628

Merged

Conversation

ElectronicBlueberry
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry commented Feb 21, 2023

closes #15612

Adds a "Tutorials" Section, if tutorials referencing current tool are available.
Feature can be turned off, or pointed to a custom API.

Screenshot from 2023-02-21 13-21-46
default collapsed state

Screenshot from 2023-02-21 13-21-29
expanded

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Member

Maybe it would be better if the new section goes after Help?

@ElectronicBlueberry
Copy link
Member Author

Since this section only appears on a subset of tools, I fear it would be missed easily if we were to move it to the bottom. What would the benefits of putting it after Help be?

@mvdbeek
Copy link
Member

mvdbeek commented Feb 21, 2023

I think it's more common that you want to look at the help or citations than the tutorial, so having it come last (or completely collapsed by default) seems like the least intrusive change.

@ElectronicBlueberry
Copy link
Member Author

It is collapsed by default

@mvdbeek
Copy link
Member

mvdbeek commented Feb 21, 2023

That's how it looks like for me:

Screenshot 2023-02-21 at 15 44 19

I would prefer this not to be before the actual help, which is much more relevant than any of the tutorials.

@ElectronicBlueberry
Copy link
Member Author

This section only appears on ~10% of tools. I fear moving a section which only appears occasionally to the bottom will make it practically invisible, especially to newcomers who would benefit the most from this feature.

@davelopez
Copy link
Contributor

Just my 2 cents... It is a bad idea to also make the Help section collapsed by default? Then the tutorials can have a bit more visibility if placed at the end, and the user chooses what to read.

@mvdbeek
Copy link
Member

mvdbeek commented Feb 21, 2023

Or maybe there's a way to have this in the form header ?

@martenson
Copy link
Member

@davelopez taking it a bit further, we could make all the form sections obviously collapsible to make it easier to navigate around long instances

@bgruening
Copy link
Member

I think it's more common that you want to look at the help or citations than the tutorial, so having it come last (or completely collapsed by default) seems like the least intrusive change.

I agree. Linking for GTN stuff is awesome, but a well-written tool help will be more useful for the user at first. Eg. just to know what this tool is doing. It is the more condensed information about this particular tool.

This section only appears on ~10% of tools. I fear moving a section which only appears occasionally to the bottom will make it practically invisible, especially to newcomers who would benefit the most from this feature.

Agreed. But I think we should approach this problem differently. Discoverability of all information in a tool form is hard and might get harder with more that we add.
What about adding some kind of ToC? I also like to idea from @mvdbeek to put it into the tool header. What about adding a hamburger menu to the tool header which offers the ToC and you can then jump to all sections? At least this should provide better visibility. The arrow button currently is somehow hidden.

@ElectronicBlueberry
Copy link
Member Author

I've moved the tutorials down for now. I think the suggested changes for tool form navigation / discoverability are great, but out of scope for this PR.

I tried both moving it to the very bottom, and above the footer. I think having the tutorials below the footer looks strange, due to the footer being a distinct section from the rest of the tool form:

Above Footer
image

Below Footer
image

@nsoranzo
Copy link
Member

I tried both moving it to the very bottom, and above the footer. I think having the tutorials below the footer looks strange, due to the footer being a distinct section from the rest of the tool form:

Agreed, both help and tutorials provide guidance and should stay close together, while citations feel more natural at the very bottom like in a scientific paper.

@bgruening
Copy link
Member

@ElectronicBlueberry can you please rebase. We should get it in and motivate more annotations in GTN :)

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thank you @ElectronicBlueberry!

Co-authored-by: Alireza Heidari <itisalirh@gmail.com>
@dannon
Copy link
Member

dannon commented Apr 26, 2023

Unit test failures are an unrelated network timeout, looks good. I like the updated position in the form, thanks!

@dannon dannon merged commit 4796634 into galaxyproject:dev Apr 26, 2023
38 of 40 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Link to training materials from tools
8 participants