New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suggested Training material to Tool Form #15628
Add suggested Training material to Tool Form #15628
Conversation
Maybe it would be better if the new section goes after Help? |
Since this section only appears on a subset of tools, I fear it would be missed easily if we were to move it to the bottom. What would the benefits of putting it after Help be? |
I think it's more common that you want to look at the help or citations than the tutorial, so having it come last (or completely collapsed by default) seems like the least intrusive change. |
It is collapsed by default |
This section only appears on ~10% of tools. I fear moving a section which only appears occasionally to the bottom will make it practically invisible, especially to newcomers who would benefit the most from this feature. |
Just my 2 cents... It is a bad idea to also make the Help section collapsed by default? Then the tutorials can have a bit more visibility if placed at the end, and the user chooses what to read. |
Or maybe there's a way to have this in the form header ? |
@davelopez taking it a bit further, we could make all the form sections obviously collapsible to make it easier to navigate around long instances |
I agree. Linking for GTN stuff is awesome, but a well-written tool help will be more useful for the user at first. Eg. just to know what this tool is doing. It is the more condensed information about this particular tool.
Agreed. But I think we should approach this problem differently. Discoverability of all information in a tool form is hard and might get harder with more that we add. |
I've moved the tutorials down for now. I think the suggested changes for tool form navigation / discoverability are great, but out of scope for this PR. I tried both moving it to the very bottom, and above the footer. I think having the tutorials below the footer looks strange, due to the footer being a distinct section from the rest of the tool form: |
Agreed, both help and tutorials provide guidance and should stay close together, while citations feel more natural at the very bottom like in a scientific paper. |
@ElectronicBlueberry can you please rebase. We should get it in and motivate more annotations in GTN :) |
rename repository to owner
show help section conditionally
474067b
to
a8aa365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thank you @ElectronicBlueberry!
Co-authored-by: Alireza Heidari <itisalirh@gmail.com>
Unit test failures are an unrelated network timeout, looks good. I like the updated position in the form, thanks! |
This PR was merged without a "kind/" label, please correct. |
closes #15612
Adds a "Tutorials" Section, if tutorials referencing current tool are available.
Feature can be turned off, or pointed to a custom API.
default collapsed state
expanded
How to test the changes?
(Select all options that apply)
License