Clarify area github tags. #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - ``area/reports`` | ||
| - ``area/system`` - Changes to scripts used to run or manage Galaxy. | ||
| - ``area/tools`` - Changes to specific tools in Galaxy. | ||
| - ``area/tooling`` - Changes to Galaxy's tool framework. |
There was a problem hiding this comment.
area/tool-framework as for datatype-framework ?
There was a problem hiding this comment.
I prefer tooling - seems pithier - though I admit it introduces some asymmetry. Do you have a strong preference.
There was a problem hiding this comment.
Not really, but tooling is not that clear to me. Maybe someone will jump in and break the tie.
|
👍 |
|
@nsoranzo I made the requested modification to |
| - ``area/UI-UX`` | ||
| - ``area/util`` | ||
| - ``area/visualization`` |
There was a problem hiding this comment.
area/visualizations (with final "s")?
#nitpickingoftheday
|
thanks guys |
|
I modified the labels in GitHub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still trying to work through our tag metadata for PRs 16.01 - it is taking a long time. I want to take a break to refine the areas based on my experiences so far. Other people have just been adding tags as they feel like I think, this has an appeal to efficiency - but I don't feel comfortable making such unilateral changes though. So against my better judgement I going to try to propose a policy regarding area tags so we can discuss these.
This PR moves the definitive list into the project so it requires a PR for modification, updates the existing list mentioned in-document to reflect the current state of Galaxy, and puts forward several new tags and one rename to an existing tag.
* Basically all the
area/toolsPRs in my opinion should bearea/toolingandarea/toolsshould be reserved for changes to actual tools. This would mirror the newdatatypestag which would let someone filter on changes to actual implemented datatypes (the idea being that changes to specific tools are datatypes are more interesting to deployers and changes to the datatype framework and tooling framework are more interesting to developers).