Emit filterText to HistoryPanel from historyStore #15926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamidawan
changed the title
|
Nice! Those integrations are really cool. Great to see what is possible now. |
ahmedhamidawan
force-pushed
the
emit_related_filter_without_panel
branch
from
9699a9c
to
e095db5
Compare
dannon
reviewed
Apr 25, 2023
| @@ -55,7 +55,7 @@ | |||
| <b-button | |||
| v-if="showHighlight" | |||
| class="highlight-btn px-1" | |||
| title="Show Inputs for this item" | |||
| title="Show Related Items" | |||
There was a problem hiding this comment.
Thanks, I saw this text was out of date when looking at the other related filter PR, glad to see it fixed here! :)
dannon
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a variable in
historyStorecalledcurrentFilterTextthat tracks the filter in the current history in the history panel.filterTextcan then be emitted to the active historyPanel from anywhere in Galaxy.E.g.: Clicking on the related filter button (
sitemapicon) on a history content item will emit filter text:related:hidand change the history to the history containing that itemScreen.Recording.2023-04-24.at.4.33.28.PM.mov
How to test the changes?
(Select all options that apply)
License