Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Fix optional fields being validated as missing in ts api #16141

Merged
merged 1 commit into from Jun 4, 2023
Merged

[23.0] Fix optional fields being validated as missing in ts api #16141

merged 1 commit into from Jun 4, 2023

Conversation

jmchilton
Copy link
Member

Fixes #16135

How to test the changes?

(Select all options that apply)

  • I don't know how to test this - but the stack trace looks legit and the fix looks like it would help.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon
Copy link
Member

dannon commented May 23, 2023

xref #16139...

mvdbeek
mvdbeek approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft ?

@jmchilton jmchilton marked this pull request as ready for review June 1, 2023 13:14
@github-actions github-actions bot added this to the 23.0 milestone Jun 1, 2023
@bgruening bgruening merged commit 13d644f into galaxyproject:release_23.0 Jun 4, 2023
35 of 37 checks passed
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmchilton @dannon @mvdbeek @bgruening