Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate display applications API to Fast API #16156

Merged
merged 5 commits into from May 30, 2023

Conversation

heisner-tillman
Copy link
Contributor

@heisner-tillman heisner-tillman commented May 29, 2023

This is a part of #10889.

Summary

  • Add pydantic models
  • Operations now return pydanctic models
  • Removed the mapping to the legacy route and add FastAPI routes

How to test the changes?

manual_testing_display_applications

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks a lot!

@mvdbeek mvdbeek merged commit fa29730 into galaxyproject:dev May 30, 2023
51 of 52 checks passed
@mvdbeek mvdbeek added the kind/refactoring cleanup or refactoring of existing code, no functional changes label May 30, 2023
@galaxyproject galaxyproject deleted a comment from github-actions bot May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants