Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to create new activity bar items #16196

Merged
merged 33 commits into from Jun 13, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jun 6, 2023

Requires: #16184. Provides a framework to allow users to drag items from the UI into the activity bar component. Demonstrated here for datasets and workflows. The context menu has been augmented, now allowing to search activities.

Screen.Recording.2023-06-08.at.6.07.49.PM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 23.1 milestone Jun 6, 2023
@hexylena hexylena added the highlight/power-user Included at bottom of user-facing release notes (please use either this or highlight, but not both) label Jun 7, 2023
@guerler guerler force-pushed the activity_drag branch 3 times, most recently from 2634679 to 2f7c53f Compare June 9, 2023 05:48
@guerler guerler marked this pull request as ready for review June 9, 2023 11:58
@mvdbeek
Copy link
Member

mvdbeek commented Jun 9, 2023

I've got 2 Workflow activities now, Workflow and Workflows:

Screenshot 2023-06-09 at 17 46 31

@guerler guerler force-pushed the activity_drag branch 3 times, most recently from 54d11f2 to 52adcc8 Compare June 10, 2023 12:42
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing ... it's so good I'm a little sad we're not making that the default yet 😆

@bgruening
Copy link
Member

Hüstle... Let's make it default ;-)

@guerler
Copy link
Contributor Author

guerler commented Jun 13, 2023

Thanks for all the comments and help. I really appreciate it! I think we should refine the list of activities first and then consider switching this feature on by default.

@guerler guerler merged commit 4788277 into galaxyproject:dev Jun 13, 2023
17 checks passed
@guerler guerler deleted the activity_drag branch June 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX highlight/power-user Included at bottom of user-facing release notes (please use either this or highlight, but not both) kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants