Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.05] Bump version of chromedriver setup action #16461

Merged
merged 5 commits into from
Jul 26, 2023
Merged

[22.05] Bump version of chromedriver setup action #16461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37977eb
Bump version of chromedriver setup action
mvdbeek Jul 25, 2023
eee8632
Use upstream command to install chrome and chromedriver
mvdbeek Jul 26, 2023
b56d785
Use action
mvdbeek Jul 26, 2023
989551d
Externalize selenium setup with reusable workflow
mvdbeek Jul 26, 2023
b9c07a7
Use reusable workflow in all selenium workflows
mvdbeek Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/integration_selenium.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
setup-selenium:
uses: ./.github/workflows/setup_selenium.yaml
test:
name: Test
needs: setup-selenium
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -66,7 +69,6 @@ jobs:
- uses: mvdbeek/gha-yarn-cache@master
with:
yarn-lock-file: 'galaxy root/client/yarn.lock'
- uses: nanasess/setup-chromedriver@v1
- name: Run tests
run: ./run_tests.sh --coverage -integration test/integration_selenium
working-directory: 'galaxy root'
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/selenium.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
setup-selenium:
uses: ./.github/workflows/setup_selenium.yaml
test:
name: Test
needs: setup-selenium
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -66,7 +69,6 @@ jobs:
- uses: mvdbeek/gha-yarn-cache@master
with:
yarn-lock-file: 'galaxy root/client/yarn.lock'
- uses: nanasess/setup-chromedriver@v1
- name: Run tests
run: ./run_tests.sh --coverage -selenium lib/galaxy_test/selenium -- --num-shards=3 --shard-id=${{ matrix.chunk }}
working-directory: 'galaxy root'
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/selenium_beta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
setup-selenium:
uses: ./.github/workflows/setup_selenium.yaml
test:
name: Test
needs: setup-selenium
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -68,7 +71,6 @@ jobs:
- uses: mvdbeek/gha-yarn-cache@master
with:
yarn-lock-file: 'galaxy root/client/yarn.lock'
- uses: nanasess/setup-chromedriver@v1
- name: Run tests
run: ./run_tests.sh --coverage -selenium lib/galaxy_test/selenium -- --num-shards=3 --shard-id=${{ matrix.chunk }}
working-directory: 'galaxy root'
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/setup_selenium.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
on:
workflow_call:
jobs:
setup_chromedriver:
runs-on: ubuntu-latest
steps:
- name: Install chromedriver
uses: mvdbeek/setup-chromedriver@chromedriver_puppeteer
Loading