Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.05] Bump version of chromedriver setup action #16461

Merged
merged 5 commits into from Jul 26, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 25, 2023

Saw a failure on #15933, not sure if related.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member Author

mvdbeek commented Jul 25, 2023

Seems that google would prefer that one uses https://googlechromelabs.github.io/chrome-for-testing/, but that's not been updated in the action ... and also it seems to work again now.

@mvdbeek mvdbeek force-pushed the chromedriver_bump branch 2 times, most recently from b08e08c to 6c9361a Compare July 26, 2023 10:09
@mvdbeek
Copy link
Member Author

mvdbeek commented Jul 26, 2023

I've also externalized the chromedriver setup into a reusable workflow. When nanasess/setup-chromedriver#191 gets merged we only need to update the action version in a single place, and we also don't need to run the setup in each job. We should probably do more of this, things like the client build in selenium could also just happen once.

@mvdbeek mvdbeek merged commit 075e630 into galaxyproject:release_22.05 Jul 26, 2023
31 of 36 checks passed
@nsoranzo nsoranzo deleted the chromedriver_bump branch July 26, 2023 12:05
@nsoranzo nsoranzo modified the milestones: 23.0, 23.1 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants