Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Make sure job_wrapper uses a consistent metadata strategy #16569

Merged
merged 1 commit into from Aug 18, 2023
Merged

[23.0] Make sure job_wrapper uses a consistent metadata strategy #16569

merged 1 commit into from Aug 18, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 17, 2023

This should fix #16309

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.0 milestone Aug 17, 2023
@mvdbeek mvdbeek force-pushed the fix_selection_of_interactive_tool_metadata_strategy branch from ada1a01 to 62677c9 Compare August 17, 2023 15:10
@mvdbeek mvdbeek requested a review from a team August 17, 2023 15:12
jmchilton
jmchilton approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks great to me!

@bgruening
Copy link
Member

It indeed fixes #16309. I deployed on EU and tested it.

Thanks @mvdbeek

@bgruening bgruening merged commit 92138e9 into galaxyproject:release_23.0 Aug 18, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/jobs kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvdbeek @bgruening @jmchilton