Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] FileInput no longer accept 'U' in the file mode #16704

Merged
merged 1 commit into from Sep 17, 2023

Conversation

bgruening
Copy link
Member

From the 3.11 release notes:

FileInput no longer accept 'U' (“universal newline”) in the file mode. In Python 3, “universal newline” mode is used by default whenever a file is opened in text mode, and the 'U' flag has been deprecated since Python 3.3.

See also https://docs.python.org/3.5/library/functions.html#open

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Sep 16, 2023
@mvdbeek mvdbeek changed the title FileInput no longer accept 'U' in the file mode [23.1] FileInput no longer accept 'U' in the file mode Sep 17, 2023
@mvdbeek mvdbeek merged commit 3e991f1 into galaxyproject:release_23.1 Sep 17, 2023
37 of 39 checks passed
@bgruening bgruening deleted the universial_newline branch September 17, 2023 08:01
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants