Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix public archived histories not importable #16766

Conversation

davelopez
Copy link
Contributor

Fixes #16764 (sorry for the oversight)

In addition, it displays the message This history has been archived. only to the owner of the history. Now, the owner will see the Switch to this history button but will be disabled.

Owner View

image

Non-owner user View

image

How to test the changes?

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Sep 29, 2023
@nsoranzo
Copy link
Member

Would it be useful to add a tooltip to the "Switch to this history" button explaining why it is disabled?

@davelopez
Copy link
Contributor Author

It certainly wouldn't hurt, but it would be kind of redundant as the reason is displayed in the message at the top, it is either the history is archived, purged, or already current (which should be pretty obvious too).

@nsoranzo
Copy link
Member

It certainly wouldn't hurt, but it would be kind of redundant as the reason is displayed in the message at the top, it is either the history is archived, purged, or already current (which should be pretty obvious too).

Yes, but that assumes the user knows/remembers that you cannot switch to an archived history 😅

@davelopez
Copy link
Contributor Author

Good point 😆
I'll add a tooltip then 👍

@davelopez davelopez marked this pull request as draft September 29, 2023 15:39
@davelopez
Copy link
Contributor Author

Done!

Now it should tell the reason for it being disabled on hover.

image

@nsoranzo
Copy link
Member

Great, thanks!

@nsoranzo nsoranzo closed this Sep 29, 2023
@nsoranzo nsoranzo reopened this Sep 29, 2023
@nsoranzo
Copy link
Member

Sorry, wrong button!

@davelopez davelopez marked this pull request as ready for review September 29, 2023 15:54
@bgruening bgruening merged commit 79cb585 into galaxyproject:release_23.1 Sep 29, 2023
22 of 34 checks passed
@davelopez davelopez deleted the 23.1_fix_archived_history_not_importable branch September 29, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants