Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Disable button in CopyModal for histories when copying history #16793

Merged

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Oct 5, 2023

Disable the Copy History | Saving... button in the copy history modal. If not disabled, it allows you to click the Saving... button repeatedly, copying the history multiple times.

Bug:

Screen.Recording.2023-10-05.at.4.10.22.PM.mov

You end up with the same history many times...

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 5, 2023
@ahmedhamidawan ahmedhamidawan changed the title Disable button in CopyModal for histories when copying history [23.1] Disable button in CopyModal for histories when copying history Oct 5, 2023
@ahmedhamidawan ahmedhamidawan modified the milestones: 23.2, 23.1 Oct 5, 2023
@bgruening bgruening merged commit df8642f into galaxyproject:release_23.1 Oct 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants