Add test and doc showing how dynamic selects are used #16885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
changed the title
bernt-matthias
added a commit
to bernt-matthias/tools-iuc
that referenced
this pull request
Oct 20, 2023
when iterating over dynamic selects one can not access the fields property, but name and path column need to be set manually for the select options, xref galaxyproject/galaxy#16885 this never worked since there is obviously no element_identifier attribute even if `.fields.path` would exist.
bernt-matthias
added a commit
to bernt-matthias/tools-iuc
that referenced
this pull request
Oct 20, 2023
when iterating over dynamic selects one can not access the fields property, but name and path column need to be set manually for the select options, xref galaxyproject/galaxy#16885 this never worked since there is obviously no element_identifier attribute even if `.fields.path` would exist.
5 tasks
bgruening
pushed a commit
to galaxyproject/tools-iuc
that referenced
this pull request
Nov 12, 2023
when iterating over dynamic selects one can not access the fields property, but name and path column need to be set manually for the select options, xref galaxyproject/galaxy#16885 this never worked since there is obviously no element_identifier attribute even if `.fields.path` would exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled to get dynamic selects with
multiple="true"to work. The problem is that when iterating over the select in the command section one can not access thefieldsproperty (e.g.,.fields.path).Q: Do we want consistent access to select options for
multiple="true"andmultiple="false". A potential problem is that we can access only the value of one column in thetruecase (whereas we can access all viafieldsin thefalsecase).Docs would also be nice. Where should I put it? https://docs.galaxyproject.org/en/master/dev/schema.html#tool-inputs-param-options?
How to test the changes?
(Select all options that apply)
License