Migrate groups API to fastAPI #17051
Merged
+358
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arash77
force-pushed
the
migrate_groups_fastapi
branch
2 times, most recently
from
73aa6d2
to
3095fda
Compare
davelopez
reviewed
Nov 20, 2023
davelopez
reviewed
Nov 21, 2023
davelopez
reviewed
Nov 21, 2023
davelopez
reviewed
Nov 22, 2023
davelopez
approved these changes
Nov 22, 2023
|
Looks like there are some conflicts now, I recommend you use rebase to fix the conflict instead of merging the dev branch to have a cleaner list of commits. |
Change create response to a single group response instead of a list Add response for update Fixing url parameter
Add name for group_users and group_roles endpoints
arash77
force-pushed
the
migrate_groups_fastapi
branch
from
a70a5a1
to
361522d
Compare
|
Test failures seem unrelated and fail intermittently in other PRs too. Thank you @arash77 for addressing all the comments! 👍 |
|
This PR was merged without a "kind/" label, please correct. |
davelopez
added
the
kind/refactoring
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
test/integration/groupsAPI logic so all the logic is contained in theGroupsManagerclassrelated to: #10889
Why did you make this change?
This is part of the efforts to migrate the full Galaxy API to FastAPI see #10889.
How to test the changes?
License