Merge release_23.1 into dev #17056
Merged
Merge release_23.1 into dev #17056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes galaxyproject#16987, though there's probably something to be done for loc files being loaded from tools. At the minimum this is a versioning issue, if a new version of featureCounts comes with a new built-in reference then an old version shouldn't use it, and vice-versa. Seems like a hard problem to solve.
…cate_log_files [23.1] Change log level for duplicate data table entries to warning
Come back and fix it in dev?
And disable submit button when request is being handled.
[23.1] Fix duplicated tools in tool panel view section copying
Admin users get all the broadcasts notifications regardless of their "activation" status so we need to apply the filtering also in the client. Regular users are not affected because they can only get active broadcasts.
…flow form This is another attempt at galaxyproject#13220, but taking into account galaxyproject#13220 (comment) by limiting this to the simplified workflow form, where we can assume input parameter optionality to have the correct meaning. This makes it harder to submit a mandatory text parameter that can be empty, but that is (at this point at least) a very fringe requirement. If really needed you can make the parameter optional (and use pick_value to fill in an empty string if null is not OK as a value).
…ast_filtering_for_admins [23.1] Fix filtering of active broadcasts for admins
…submission_missing_input_value [23.1] Prevent workflow submission with missing input values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License