Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Useful Markdown Components for Mapped Over Steps #17198

Merged
merged 3 commits into from Jan 12, 2024

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Dec 15, 2023

Builds on the markdown enhancements in #17105. Fixes #16863 for job parameters and job metrics in the GUI. I want to modernize the other two job targets (tool standard error and standard out) before making it apply to them as well. (Edit: done)

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Create a workflow with a mapped over step, give the step a label, add job metrics or job parameters component to the markdown report for the workflow, run the workflow over a small collection, render the report, see the new job selector.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review December 22, 2023 15:32
@github-actions github-actions bot added this to the 24.0 milestone Dec 22, 2023
@jmchilton jmchilton force-pushed the mapped_over_steps branch 2 times, most recently from 1d4ea63 to e1fb428 Compare December 22, 2023 22:24
@bgruening
Copy link
Member

This looks good to me. Thanks @jmchilton!
It would be nice if we could add some more documentation about "Implicit Collection Jobs" for future devs.

@jmchilton
Copy link
Member Author

It would be nice if we could add some more documentation about "Implicit Collection Jobs" for future devs.

Another slide in the Galaxy architecture slides? I don't know where I would document this otherwise.

@jmchilton jmchilton merged commit 5f3d617 into galaxyproject:dev Jan 12, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job-related parameters in invocation report don't work for map over jobs
2 participants