Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert entryPointStore to composition API + TS #17356

Merged
merged 1 commit into from Jan 26, 2024
Merged

Convert entryPointStore to composition API + TS #17356

merged 1 commit into from Jan 26, 2024

Conversation

davelopez
Copy link
Contributor

Part of #17355

Simplifies a bit the refactoring.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jan 25, 2024
@davelopez davelopez mentioned this pull request Jan 25, 2024
Merged
4 tasks
@github-actions github-actions bot added this to the 24.0 milestone Jan 25, 2024
@davelopez
Copy link
Contributor Author

The test failure test_import_workflow_by_url_workflowhub is unrelated

@bgruening bgruening merged commit c58a08d into galaxyproject:dev Jan 26, 2024
30 of 31 checks passed
@davelopez davelopez deleted the migrate_entry_points_store_ts branch January 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davelopez @bgruening