Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate resource grids into tab views #17487

Merged
merged 42 commits into from Feb 23, 2024
Merged

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Feb 17, 2024

This PR consolidates resource grids for Histories, Visualizations and Pages into tab views. Additionally this PR adds an api endpoint to undelete pages.

Screen.Recording.2024-02-19.at.2.44.41.PM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler force-pushed the grid_tabs branch 2 times, most recently from 4307a6c to f7a0726 Compare February 18, 2024 16:12
@guerler guerler added kind/bug kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Feb 19, 2024
@guerler guerler added this to the 24.0 milestone Feb 19, 2024
@guerler guerler marked this pull request as ready for review February 20, 2024 13:38
@guerler guerler added area/documentation highlight Included in user-facing release notes at the top labels Feb 20, 2024
@bgruening
Copy link
Member

Thanks @guerler! This works great for me, thanks also for adding my previous suggestions.

@mvdbeek mvdbeek merged commit 4e3ed4c into galaxyproject:dev Feb 23, 2024
56 checks passed
@guerler guerler deleted the grid_tabs branch February 23, 2024 08:51
@bgruening
Copy link
Member

Congratulations @guerler! What a great long-term effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/documentation area/UI-UX highlight Included in user-facing release notes at the top kind/bug kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants