Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Drop release notes webhook #17675

Merged
merged 1 commit into from Mar 12, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Mar 12, 2024

With the notification system in place we will be utilizing that moving forward. This also allows instances to customize release notifications (e.g. can help in the situation where a site skips a release or wants to add more to the notification -- something like "we've upgraded from 23.1 to 24.0, see these two sets of release notes", etc).

If desired, we could have migrations or some other mechanism for generating these release note notifications (or something like that), but I think deferring to admins and seeing how they use this at first could be fine.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon changed the title Drop release notes webhook [24.0] Drop release notes webhook Mar 12, 2024
@github-actions github-actions bot added this to the 24.1 milestone Mar 12, 2024
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martenson martenson added highlight/admin Included in admin/dev release notes kind/refactoring cleanup or refactoring of existing code, no functional changes area/UI-UX labels Mar 12, 2024
@martenson martenson modified the milestones: 24.1, 24.0 Mar 12, 2024
@martenson
Copy link
Member

Adding an admin highlight here as I believe this should be communicated to admins and showcased with a nice markdown example of how such a site-wide release notification looks like.

@dannon
Copy link
Member Author

dannon commented Mar 12, 2024

@martenson Good call, thank you!

@martenson martenson merged commit 62decba into galaxyproject:release_24.0 Mar 12, 2024
46 of 49 checks passed
@martenson
Copy link
Member

thanks @dannon for remembering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX highlight/admin Included in admin/dev release notes kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants