Use "Gateway" from docker inspect as default docker_hostname #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively this behaviour could be activated by setting |
| @@ -293,4 +296,4 @@ def get_proxied_ports(self, container_id): | |||
| binding['HostIp'], | |||
| binding['HostPort'] | |||
| )) | |||
| return mappings | |||
| return mappings, gateway_ip | |||
There was a problem hiding this comment.
A future version of this should probably split out the mapping adjustments into a separate method, and then just return inspect_data here.
…ecovery, fix typo.
|
@erasche I split out inspect_data and port mapping / gateway_ip. This is what you had in mind, right? |
|
@mvdbeek beautiful! This is exactly what I had in mind, though I didn't expect you to have to implement it. Thanks for doing that refactoring :) |
|
Alright then, from my side this would ready. |
hexylena
added a commit
that referenced
this pull request
Feb 22, 2016
Use "Gateway" from docker inspect as default docker_hostname
|
👍 in retrospect :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communication with containers started by interactive environments happens on a arbitrarily chosen high-number port
nnnnthat maps back into the container. If the container runs on the same machine as galaxy does, the container can be reached at localhost:nnnn. This does not work when using "docker-next-to-docker" (docker run -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker image), since the newly started container's localhost:nnnndoes not point to the host's localhost:nnnn. An easy solution for this is to instead use the Gateway.This allows using interactive environments both in docker-in-docker and docker-next-to-docker scenarios.
See here for some background why docker-next-to-docker is preferrable over docker-in-docker.
Normal operation on localhost will work fine as well, and remote communication will not be affected, so I hope this will be an acceptable default setting.