-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change InvocationsList
into a grid using GridList
#18088
Change InvocationsList
into a grid using GridList
#18088
Conversation
https://github.com/ahmedhamidawan/galaxy/tree/invocations_panel In this ^ branch, I have added an Invocations Panel for the invocations activity: invocations_activity_panel_second.mp4Commit: 984341a |
56ea5b5
to
d19c953
Compare
The python linting failures are for |
Yep, they are solved on dev, you can rebase to get rid of them. |
This removes the `InvocationsList` component and instead uses the `GridList`. To make this possible, a few changes were made to the Grid components (such as more field types, non-filterable grid, expandable rows etc.). The invocations list now appears uniform with the other grids due to this change.
d19c953
to
c9c824a
Compare
This removes the
InvocationsList
component and instead uses theGridList
. To make this possible, a few changes were made to the Grid components (such as more field types, non-filterable grid, expandable rows etc.).The invocations list now appears uniform with the other grids due to this change:
One tricky thing here is that; to make expandable rows possible, I had to change the table in
GridList
from:to:
One alternative is that, we remove the expandable rows functionality (which allows you to see multiple invocations in one table) and instead rely on the invocations panel (screencast below; done in a separate PR) to quick-switch between invocations?
This also adds a
Import Invocation
button at the top right, which fixes part of #18047How to test the changes?
(Select all options that apply)
License