Move scripts out of lib/tool_shed.

[davebx]

No description provided.

[jmchilton]

The minor tag means it changes made by devteam members to features released this cycle - it doesn't apply here.

[nsoranzo]

This should be

sys.path.insert(1, os.path.join(os.path.dirname( __file__ ), os.pardir, os.pardir, os.pardir, 'lib'))

[nsoranzo]

sys.path.insert() should be updated also in scripts/tool_shed/bootstrap_tool_shed/create_user_with_api_key.py and the other Python files following it in the list of moved files.

[davebx]

@jmchilton Where is this documented? I should probably bookmark that page.

[martenson]

@davebx https://github.com/galaxyproject/galaxy/blob/dev/doc/source/project/issues.rst or https://docs.galaxyproject.org/en/master/project/issues.html

[jmchilton]

👍 It wasn't really obvious to me at first that scripts belong in scripts/ and not lib/ but I think these do since they mess with sys.path. I think as a design goal - nothing in lib/ should be messing with sys.path - all modules in lib should be importable, side-effect free, without errors if non-optional dependencies are available.

[davebx]

@jmchilton In addition to the above, with which I agree, I don't see lib/ being appropriate for scripts run from the command line, nor scripts/ being appropriate for modules loaded into galaxy, the toolshed, or whichever app one is dealing with.

[nsoranzo]

@davebx sys.path.insert() still need to be updated in many Python files moved in scripts/tool_shed/:
scripts/tool_shed/check_filesystem_for_empty_tool_dependency_installation_paths.py
scripts/tool_shed/check_repositories_for_functional_tests.py
scripts/tool_shed/check_s3_for_empty_tool_dependency_installation_paths.py
scripts/tool_shed/check_tool_dependency_definition_repositories.py
scripts/tool_shed/deprecate_repositories_without_metadata.py
scripts/tool_shed/show_tool_dependency_installation_dir_contents.py

[galaxybot]

This PR was merged without a milestone attached.

[martenson]

Is this consistent now? @nsoranzo @davebx

this seems to have caused #2121