Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place $headers before integrity_check #2146

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Apr 13, 2016

PBS needs the resource selection (which will be filled in place of $headers) to
appear before anything else (except the shebang), so this changes the order.

@mvdbeek

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2016

We may actually want to backport this to 16.01, since this is when integrity_injection was introduced, I believe.

Place $headers before integrity_check
PBS needs the resource selection (which will be filled in using $headers) to
appear before anything else (except the shebang), so this changes the order.

@galaxybot galaxybot added this to the 16.07 milestone Apr 13, 2016

@jmchilton jmchilton merged commit e81448c into galaxyproject:dev Apr 14, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

Awesome - thanks for the fix.

@mvdbeek mvdbeek deleted the mvdbeek:reorder_job_template branch Apr 15, 2016

martenson added a commit that referenced this pull request Apr 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.