[16.04] Add fixed validation check for data_source tools URL parameter #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
changed the title
guerler
force-pushed
the
fix_error_message_001
branch
from
22dea28
to
3e10cee
Compare
|
This will actually break the GenomeSpace filebrowser import tool, since the check on whether to attempt to run a tool used to be the existence of Also seems a bit hackish. It just feels like there should be a better way to handle this scenario. |
|
Which is why its tagged as WIP. |
|
Of course, didn't know if you wanted feedback yet though. Thanks for working on it. |
guerler
force-pushed
the
fix_error_message_001
branch
2 times, most recently
from
9078854
to
c419ada
Compare
guerler
force-pushed
the
fix_error_message_001
branch
from
c419ada
to
d0447fe
Compare
|
No worries, and thanks for looking into it. |
|
@galaxybot test this |
|
This seems like a legit fix to me. @blankenberg please open a PR if you have an idea how to do this better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2200,
data_sourcetools used to have aURLparameter check, preventing job execution when theURLparameter was not transmitted to thetool_runnercontroller. This PR re-introduces this check. However, instead of redirecting to the welcome page, the error is displayed. This can be tested by accessing e.g.http://127.0.0.1:8080/tool_runner?tool_id=genomespace_importerwith and without this fix.