[16.04] [WIP] Fix trimmer tool with no ignore options. #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re options, with 'trimmer.py: error: -i option requires an argument'
|
@guerler Yeah, I just checked and this worked in 16.01 with no options specified. This is probably actually an error in parameter handling. Leaving this open for now so you can see it to easily test, but this is not the right fix. |
dannon
changed the title
|
(left this open more as an 'issue' indicator to demonstrate the problem -- closing for the fix in #2234) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trimmer tool would previously fail to execute if you selected no ignore options, with
trimmer.py: error: -i option requires an argumentIs it possible this used to work but changed due to tool parameter handling? (edit: it is so)