Revise asserts triggering false exceptions for dynamic parameters #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e evaluated for initial tool models
guerler
force-pushed
the
fix_error_log_000
branch
from
247826a
to
7ab5dc3
Compare
guerler
force-pushed
the
fix_error_log_000
branch
from
bcb855e
to
d7f2e37
Compare
…lled through from_json
guerler
force-pushed
the
fix_error_log_000
branch
from
d7f2e37
to
4893e0e
Compare
guerler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some legacy assertions which trigger false sentry reports e.g. when a dependency is hidden by an alternative conditional selection. Currently, exceptions triggered by these
assertsare reported but skipped to avoid interruption of the tool model building process: https://github.com/guerler/galaxy/blob/7cf7424f2bc65325b0b877de90a40775a758d191/lib/galaxy/tools/__init__.py#L1642.In addition the PR revises some asserts in drill downs and other locations, replacing them by properly displayed
ValueErrorswhen parameters are validated throughfrom_json: https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/tools/parameters/__init__.py#L113.