Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise asserts triggering false exceptions for dynamic parameters #2374

Merged
merged 4 commits into from May 23, 2016

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented May 19, 2016

This PR removes some legacy assertions which trigger false sentry reports e.g. when a dependency is hidden by an alternative conditional selection. Currently, exceptions triggered by these asserts are reported but skipped to avoid interruption of the tool model building process: https://github.com/guerler/galaxy/blob/7cf7424f2bc65325b0b877de90a40775a758d191/lib/galaxy/tools/__init__.py#L1642.
In addition the PR revises some asserts in drill downs and other locations, replacing them by properly displayed ValueErrors when parameters are validated through from_json: https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/tools/parameters/__init__.py#L113.

@guerler guerler force-pushed the guerler:fix_error_log_000 branch from 247826a to 7ab5dc3 May 19, 2016

@guerler guerler force-pushed the guerler:fix_error_log_000 branch from bcb855e to d7f2e37 May 19, 2016

@guerler guerler force-pushed the guerler:fix_error_log_000 branch from d7f2e37 to 4893e0e May 19, 2016

@guerler guerler changed the title Remove asserts triggering false exceptions for dynamic parameters Revise asserts triggering false exceptions for dynamic parameters May 19, 2016

@jmchilton jmchilton merged commit a9c94bd into galaxyproject:dev May 23, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.