Fix raven.js import order in galaxy.panels.mako #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raven now uses a UMD and checks for requirejs removing it from globals if found. This adds a require import to load Raven.
Moves galaxy.panels.mako's import of Raven back to vanilla script tag and before the requirejs library import, allowing Raven's UMD to define Raven as a global. This starts Raven/sentry *before* the library package is loaded so that library errors can be captured as well.
|
superb! thank you @carlfeberhard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to raven.js included a UMD which, if raven was imported after requirejs, would only provide an AMD importing interface to raven. This caused an error in galaxy.panels.mako where it's imported after requirejs and tries to use the global. The error only appeared on instances configured for sentry.
This changes the order of import of raven.js on galaxy.panels.mako so it comes before the import of requirejs allowing us to continue using the global. An AMD import is entrirely possible, but the (second) change here makes the raven import pattern consistent across the main templates.
Also, tracekit is removed from the client libraries since raven includes its own, internal version of it now.
Thanks to @martenson for reporting it.