Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raven.js import order in galaxy.panels.mako #2445

Merged
merged 3 commits into from
Jun 2, 2016
Merged

Fix raven.js import order in galaxy.panels.mako #2445

merged 3 commits into from
Jun 2, 2016

Commits on Jun 2, 2016

  1. Raven: fix import in galaxy.panels.mako 

    Raven now uses a UMD and checks for requirejs removing it from globals
if found. This adds a require import to load Raven.
    @carlfeberhard
    carlfeberhard committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    d458906 View commit details
    Browse the repository at this point in the history

  2. Raven: revert previous commit and move raven first 

    Moves galaxy.panels.mako's import of Raven back to vanilla script
tag and before the requirejs library import, allowing Raven's UMD
to define Raven as a global.

This starts Raven/sentry *before* the library package is loaded so that
library errors can be captured as well.
    @carlfeberhard
    carlfeberhard committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    8ef5279 View commit details
    Browse the repository at this point in the history

  3. Raven: remove tracekit as raven has its own

    @carlfeberhard
    carlfeberhard committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    f78d540 View commit details
    Browse the repository at this point in the history