Fix element_identifier unavailable with data_collection input param #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abretaud
changed the title
abretaud
changed the title
|
It should be fixed now, and it turns out it had nothing to do with conditionals |
| @@ -307,7 +307,7 @@ def to_wrapper( dataset ): | |||
| element = dataset | |||
| dataset = element.dataset_instance | |||
| kwargs["identifier"] = element.element_identifier | |||
| return self._dataset_wrapper( dataset, dataset_paths, **kwargs ) | |||
| return self._dataset_wrapper( dataset, dataset_paths, identifier = element_identifier, **kwargs ) | |||
There was a problem hiding this comment.
I don't think is needed, should be already done at line 309.
nsoranzo
added
kind/bug
status/review
area/dataset-collections
and removed
status/WIP
triage
labels
|
This looks good to me, should we merge @nsoranzo ? |
| @@ -0,0 +1,15 @@ | |||
| <tool id="identifier_conditional" name="identifier_conditional"> | |||
There was a problem hiding this comment.
Should this id be identifier_collection? Seems more proper and it's what is used at https://github.com/galaxyproject/galaxy/pull/2570/files#diff-46fef38dde830e533e91e849d89bceabR809
If yes, also this file should be renamed and the change propagated to test/functional/tools/samples_tool_conf.xml
|
Thanks @abretaud! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a (failing) test case for galaxyproject/tools-iuc/issues/857
I also added a small fix for an UnboundLocalError I encountered while writing it