Ensure proper filtering of dataset when injecting input data on workflow initialization #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low initialization
guerler
force-pushed
the
fix_filter_set
branch
4 times, most recently
from
ad7f303
to
c74d58e
Compare
guerler
force-pushed
the
fix_filter_set
branch
from
c74d58e
to
e614a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to: #2669. Currently datasets are not properly filtered by datatypes when injected on initialization. As a consequence discrepencies might occur such that the input parameter is initialized with a dataset which is not permitted in the connected step input parameter. In this case a refresh is required. This PR avoids the necessity of a refresh by properly filtering the data types upon initial injection. This can be tested as follows: add a non-tabular file to the history, and select the
Merge columnstool. The columns will not be resolved unless a refresh has been triggered. Additionally this PR touches up on the injection procedure to simplify it and improve its robustness and consistency.