-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godocker job runner #2791
Godocker job runner #2791
Conversation
I'm overhauling some of the logging in a followup commit. |
Thanks for the changes @dannon. As galaxy has many classes, the get_structure method in runner code can be used to easily find out the class of an object. |
@dannon , could you test the runner in the vagrant box ? what is merge status? |
@dannon, any news on merge ? Seems tests were ok? |
@osallou I did get it to work in the box, but because of how I had to reopen this PR I cannot be the one to merge. I just realized this was still tagged WIP, let me request review from someone else. |
@galaxybot test this |
@@ -205,6 +205,17 @@ | |||
zero (no execution) and the stderr/stdout of the k8s job is reported in galaxy (and the galaxy job set | |||
to failed) --> | |||
</plugin> | |||
<plugin id="godocker" type="runner" load="galaxy.jobs.runners.godocker:GodockerJobRunner"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a line in here about what Godocker is and maybe a link to the platform.
""" post request with query """ | ||
|
||
# remove warnings if using --no-certificate | ||
requests.packages.urllib3.disable_warnings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove this line?
This reverts the commits in #2700 which stripped out the GoDocker job runner from #2653.
Essentially, treat this as a re-open of #2653, I just had to jump through a hoop or two to get here.
Google Summer of Code 2016: Open genome informatics
Project Idea 13: Using Go-Docker to enhance Galaxy functionalities
A REST based runner for executing Galaxy jobs using GoDocker.
Go-Docker is a cluster management tool using Docker as execution/isolation system. It can be seen like Sun Grid Engine/Torque/… Using Bioinformatics dedicated Docker hub as BioShaDock, it allows Life scientists to use powerful tools in a easy and secure way while finely managing infrastructures resources. Galaxy is a user-friendly web platform originally dedicated to life sciences data analysis. If Galaxy provides amazing functionalities to enhance transparency, accessibility and reproducibility of data analysis related processes, there is still opportunities to provide more reproducibility and flexibility in the manner of using this web platform. This project idea is to integrate the Go-Docker system with Galaxy.
Galaxy is designed to run jobs on your local system by default, but it can be configured to run jobs on a cluster. The front-end Galaxy application runs on a single server as usual, but tools are run on cluster nodes instead. Here, we use GoDocker system to manage authentication, scheduling and execution of jobs.