Reload metadata and lib tools on toolbox reload #2992
Conversation
|
👍 thanks @mvdbeek! |
| @@ -63,6 +63,7 @@ def _get_new_toolbox(app): | |||
| and then adding pre-existing data managers from the old toolbox to the new toolbox. | |||
| """ | |||
| from galaxy import tools | |||
| from galaxy.tools.special_tools import load_lib_tools | |||
| from galaxy.tools.toolbox.lineages.tool_shed import ToolVersionCache | |||
There was a problem hiding this comment.
Any reason for having all these imports here instead of at the top of the file?
There was a problem hiding this comment.
Yes, but not a good one: I copied this initially from https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/config.py#L821
There was a problem hiding this comment.
And then the tests all fail. It'd be nice to unwind all of that - but we should probably do it in its own PR.
There was a problem hiding this comment.
Damn circular imports! Sorry @mvdbeek, I hoped it was an easy fix, but @jmchilton is right, a separate PR is entirely fair.
There was a problem hiding this comment.
Ahh, of course, the toolbox imports the queue worker ...
mvdbeek
force-pushed
the
reload_special_tools
branch
from
a78fa00
to
55cce84
Compare
|
Thanks a lot @mvdbeek for a quick followup! |
Ping @natefoo
I could confirm that the auto-detecting metadata breaks after toolbox reload.
With this PR it works for me, as well as history exporting.
Should close #2988.