Add tool parameter argument to parameter help #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bgruening |
|
Great @guerler - Thanks for implementing! 👍 |
| @@ -124,6 +124,9 @@ define([], function() { | |||
| tmp += '<div class="ui-table-form-info">'; | |||
| if (options.help) { | |||
| tmp += options.help; | |||
| if (options.argument) { | |||
There was a problem hiding this comment.
Maybe here we should check that options.help does not already contain options.argument to make it possible for tool developers to cleanly support old and new Galaxy syntax.
There was a problem hiding this comment.
yep, there are a ton of IUC tools which encode the argument like this.
|
👍 |
1 similar comment
|
👍 |
guerler
added a commit
that referenced
this pull request
Jun 15, 2015
Add tool parameter argument to parameter help
|
I'd say small bug. |
|
I guess this is a bug. If you include an empty help it will be shown. —Reply to this email directly or view it on GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically adds the tool parameter argument name to the parameters help text.
See: #8