Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compressed fastq peek and preview #3512

Merged

Conversation

Projects
None yet
2 participants
@mvdbeek
Copy link
Member

commented Jan 29, 2017

and unify various places in the code that open optionally compressed files.
This addresses provide 'peak' of gzipped contents of #3498.

@mvdbeek mvdbeek added this to the 17.05 milestone Jan 29, 2017

@mvdbeek mvdbeek force-pushed the mvdbeek:add_compressed_fastq_peek_and_preview branch from 8b25459 to c0b64ee Jan 29, 2017

@mvdbeek mvdbeek force-pushed the mvdbeek:add_compressed_fastq_peek_and_preview branch from c0b64ee to 7075d79 Jan 29, 2017

@jmchilton jmchilton merged commit 1dbe75f into galaxyproject:dev Feb 3, 2017

4 checks passed

api test Build finished. 256 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 137 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Feb 3, 2017

Wonderful as always - thanks a ton @mvdbeek!

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Feb 3, 2017

Allow decompressing test outputs.
This seems to be needed to test fastq outputs from tools. Gzipped files seem to depend on the file name before compression - so diff compares (even binary ones) do not work. This allows comparing compressed outputs (and it will magically work if the expected file in test-data is compressed or not).

Builds on the awesome work from @mvdbeek in galaxyproject#3512.

@mvdbeek mvdbeek deleted the mvdbeek:add_compressed_fastq_peek_and_preview branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.