Allow decompressing tool test outputs. #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be needed to test fastq outputs from tools. Gzipped files seem to depend on the file name before compression - so diff compares (even binary ones) do not work. This allows comparing compressed outputs (and it will magically work if the expected file in test-data is compressed or not). Builds on the awesome work from @mvdbeek in galaxyproject#3512.
This was referenced Feb 3, 2017
|
Excellent! |
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Feb 3, 2017
Missed this in galaxyproject#3550. Thanks to @mvdbeek for the catch galaxyproject/tools-devteam#449 (comment).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be needed to test fastq outputs from tools. Gzipped files seem to depend on the file name before compression - so diff compares (even binary ones) do not work. This allows comparing compressed outputs (and it will magically work if the expected file in test-data is compressed or not).
Builds on the awesome work from @mvdbeek in #3512.