Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a task to protect the release branch in github #3562

Merged
merged 3 commits into from Feb 6, 2017

Conversation

Projects
None yet
5 participants
@martenson
Copy link
Member

commented Feb 5, 2017

to the release process
should prevent #3560 (comment)
thanks @nsoranzo

add a task to protect the release branch in github
to the release process
should prevent #3560 (comment)
thanks @nsoranzo
@mvdbeek

mvdbeek approved these changes Feb 5, 2017

@galaxybot galaxybot added this to the 17.05 milestone Feb 5, 2017

@martenson

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2017

unrelated api test fails

@@ -161,6 +161,8 @@
- [ ] Open PRs from your fork of branch ``version-${version}`` to upstream ``release_${version}`` and of ``version-${next_version}.dev`` to ``dev``.
- [ ] Open PR against ``release_${version}`` branch to pin flake8 deps in tox.ini to the latest available version. See [example](https://github.com/galaxyproject/galaxy/pull/3476).
- [ ] Update ``next_milestone`` in [P4's configuration](https://github.com/galaxyproject/p4) to `${next_version}` so it properly tags new PRs.
- [ ] Set the ``release_${version}`` branch in GitHub [setings](https://github.com/galaxyproject/galaxy/settings/branches) as protected.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Feb 5, 2017

Member

s/setings/settings/

@jmchilton jmchilton merged commit d628248 into galaxyproject:dev Feb 6, 2017

4 of 5 checks passed

api test Build finished. 261 tests run, 0 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 138 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented Feb 6, 2017

Thanks @martenson!

@martenson martenson deleted the martenson:protect-release-branch branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.