Revision of tool xml reloading feature #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankenberg
changed the title
|
@galaxybot test this |
guerler
force-pushed
the
fix_tool_reload_003
branch
from
0d640a9
to
73b8fc4
Compare
guerler
changed the title
|
Works great for me, merging locally to resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly revises the tool reload option in the tool form.
The reload api endpoint now returns a dictionary instead of an HTML response, the admin controller mako has been modified to render HTML from that dictionary
The api throws an exception if the tool is unavailable instead of returning
status='error'through a success messageThe success/error message is shown for a few seconds in the tool forms message view instead of displaying a modal
Styles are aligned to the tool form base class, and unused tooltips for dropdown items have been removed