Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle boolean values when parsed to a string-based/default tool parameter #3702

Merged
merged 2 commits into from Mar 8, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Mar 3, 2017

Fixes #3697. When encoding and decoding a default parameters value, boolean values should not be auto converted through json loads.

@guerler guerler added this to the 17.05 milestone Mar 3, 2017

@guerler guerler requested a review from blankenberg Mar 3, 2017

@guerler guerler force-pushed the guerler:fix_boolean_handling branch 2 times, most recently from ba2979b to 43500e7 Mar 3, 2017

guerler added some commits Mar 3, 2017

@guerler guerler force-pushed the guerler:fix_boolean_handling branch from 43500e7 to cb27f92 Mar 3, 2017

@guerler guerler removed the request for review from blankenberg Mar 4, 2017

@dannon

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

+1, works for me.

@dannon dannon merged commit 704e6a6 into galaxyproject:dev Mar 8, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.