BUG: Return empty list if resolve_all() has failed #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve the problems pointed out by 👀 @nsoranzo introduced in galaxyproject#3725. This commit also clarifies this behaviour in the docstrings.
nsoranzo
reviewed
Mar 13, 2017
| Unsuccessfull attempts should return an empty list. | ||
|
|
||
| :param requirements: list of tool requirements | ||
| :param type: [ToolRequirement] or ToolRequirements |
There was a problem hiding this comment.
Can you insert a blank line and then :returns: list of resolved dependencies?
Also, the current implementation does not support ToolRequirements yet, I think, is that a future plan?
There was a problem hiding this comment.
We are currently passing in ToolRequirements instances. The requirements attribute in Tool instances are instances of ToolRequirements objects ( https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/tools/deps/requirements.py#L225). So we support both lists of ToolRequirement instances and ToolRequirements instances, but I think we are usually not using lists of ToolRequirement instances.
nsoranzo
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the problems pointed out by 👀 @nsoranzo
introduced in #3725.
This commit also clarifies this behaviour in the docstrings.