Allow non-terminal datasets in list collection builder. #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
allow_non_ready
branch
from
3e9b81e
to
3c6989e
Compare
This includes two parallel changes to the Selenium tests. - It adds a decorator to allow retrying certain atomic actions that may occur during jQuery transitions automatically. - It refactors things to allow waiting on HIDs to become visible instead of just green.
jmchilton
force-pushed
the
allow_non_ready
branch
from
3c6989e
to
17e5407
Compare
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 21, 2017
Reworks addition of staleness checkers introduced in galaxyproject#3780.
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 22, 2017
Reworks addition of staleness checkers introduced in galaxyproject#3780.
jmchilton
added a commit
to jmchilton/galaxy
that referenced
this pull request
Mar 24, 2017
Reworks addition of staleness checkers introduced in galaxyproject#3780.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did more testing and these seem to work fine - or at least no worse than 'OK' datasets. Also the pair list builder already allow these.
This includes two parallel changes to the Selenium tests.