Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for driving Qunit tests. #3810

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Mar 23, 2017

  • Drop explicit requirement on phantomjs since we are moving away from explicit phantomjs testing (it is still pulled in by QUnit which is fine).
  • If npm install . has previously been executed from the test/qunit, don't require globally available grunt to run the tests via run_tests.sh -q.
Small improvements to Qunit tests.
- Drop explicit requirement on phantomjs since we are moving away from explicit phantomjs testing (it is still pulled in by QUnit which is fine).
- If ``npm install .`` has previously been executed from the ``test/qunit``, don't require globally available grunt to run the tests via ``run_tests.sh -q``.
@nsoranzo
Copy link
Member

left a comment

Fantastic, I can now drop one step from my "Galaxy testing setup" notes.

@nsoranzo nsoranzo merged commit 9e61aff into galaxyproject:dev Mar 23, 2017

5 checks passed

api test Build finished. 267 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.