Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ToolConfWatcher watch ToolCache #3814

Merged
merged 6 commits into from
Mar 25, 2017
Merged

Make ToolConfWatcher watch ToolCache #3814

merged 6 commits into from
Mar 25, 2017

Commits on Mar 24, 2017

  1. Make ToolConfWatcher watch ToolCache 

    If any item in the tool cache has changed (local tool update, repository
update, tool deleted) the toolbox will be reloaded and any tool changes are
applied.

Should fix galaxyproject#3813.
    @mvdbeek
    mvdbeek committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    ad68b15 View commit details
    Browse the repository at this point in the history

  2. Fix ToolConfWatcher test: can only watch existing files

    @mvdbeek
    mvdbeek committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    c91c988 View commit details
    Browse the repository at this point in the history

  3. Only call tool_cache.cleanup if tool_cache exists

    @mvdbeek
    mvdbeek committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    5be7ebe View commit details
    Browse the repository at this point in the history

  4. Fix toolshed startup by setting tool_cache to None (the toolshed lo… 

    …ads an empty toolbox)
    @mvdbeek
    mvdbeek committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    4d9cf64 View commit details
    Browse the repository at this point in the history

  5. Wrap tool_cache cleanup in try/except clause

    @mvdbeek
    mvdbeek committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    0bf2493 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2017

  1. Improve ToolCache cleanup logic 

    Pull `removed_tool_ids` out of try/except, so that we can return
`removed_tool_ids` even if an exception occured. Fix a typo in the
`_should_cleanup` docstring. Many thanks for the suggestions @nsoranzo.
    @mvdbeek
    mvdbeek committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    197aa40 View commit details
    Browse the repository at this point in the history