Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root redirect for backbone router #3837

Merged
merged 2 commits into from Apr 27, 2017

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Mar 29, 2017

Naive client-side redirect approach.

@guerler guerler added the status/WIP label Mar 29, 2017

@guerler guerler requested a review from dannon Mar 29, 2017

@guerler guerler force-pushed the guerler:login_routes branch from ee1cd3c to f369ab0 Mar 29, 2017

@guerler guerler changed the title [WIP] Add login redirect for backbone router [WIP] Add root redirect for backbone router Mar 29, 2017

@guerler guerler changed the title [WIP] Add root redirect for backbone router Add root redirect for backbone router Apr 27, 2017

@guerler guerler added status/review and removed status/WIP labels Apr 27, 2017

@galaxybot galaxybot added this to the 17.05 milestone Apr 27, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

@guerler do you want to get this to 17.05?

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

@martenson Yeah, we're going to get it in there. I was just talking to @guerler about it a few minutes ago and have some future work, but I'll be merging it locally to resolve conflicts in a sec.

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

(merging locally, fixes the bug, but I'm going to try to follow it up quickly with a few more changes)

@dannon dannon merged commit e431af0 into galaxyproject:dev Apr 27, 2017

5 checks passed

api test Build finished. 271 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 140 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 25 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.